Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix issue with inconsistent CSF ordering in sandboxes #20705

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Core: Fix issue with inconsistent CSF ordering in sandboxes #20705

merged 3 commits into from
Jan 24, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 20, 2023 •
edited
Loading

Fixes: #20626

What I did

  • Create sandbox a little more serially to ensure the stories field of main.js is consistent (this was the issue)
  • Split async calculation from cache storage to avoid race conditions in the indexer (this wasn't actually a problem but seems like it'll help with confusion).

How to test

Run the build-storybook several times. I did it in this some CI jobs:

  1. to come

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from shilman January 20, 2023 07:36
@tmeasday
Copy link
Member Author

Ok, it didn't work 🤔

https://app.circleci.com/pipelines/github/storybookjs/storybook/39052/workflows/29a65d28-e1d0-4fef-b9bc-d7ae2b0b5b52/jobs/472878/parallel-runs/1?filterBy=ALL

https://app.circleci.com/pipelines/github/storybookjs/storybook/39052/workflows/c6b1fba8-3f54-4b04-861a-3d54c83de7f5/jobs/472876/parallel-runs/1?filterBy=ALL

https://app.circleci.com/pipelines/github/storybookjs/storybook/39052/workflows/2ccd5621-f8da-4491-baa5-178ec2f6fe0d/jobs/472879

@tmeasday
Copy link
Member Author

Worked with the serialization in tasks/sandbox:

shilman
shilman approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@shilman shilman changed the title Core: Fix issue with inconsistent CSF ordering in sandboxes. Core: Fix issue with inconsistent CSF ordering in sandboxes Jan 24, 2023
@tmeasday tmeasday merged commit bcca0cc into next Jan 24, 2023
@tmeasday tmeasday deleted the >20626-fix-inconsistent-order branch January 24, 2023 10:30
@shilman shilman mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@tmeasday tmeasday

Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Order of stories inconsistent in built Storybooks
2 participants
@tmeasday @shilman